Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor | CAKK-92 | 어드민 서버 코드 리팩토링 #220

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Refactor | CAKK-92 | 어드민 서버 코드 리팩토링 #220

merged 3 commits into from
Oct 4, 2024

Conversation

lcomment
Copy link
Collaborator

@lcomment lcomment commented Oct 3, 2024

Issue Number

CAKK-92

Description

  • API 모듈과 같이 Admin 모듈도 리팩토링 했습니다.
  • Security에 대한 간단한 환경을 구성했습니다.

etc

@lcomment lcomment added chore 빌드 매니저 및 환경 설정 refactor 비즈니스 변경 없는 수정 labels Oct 3, 2024
@lcomment lcomment requested a review from YongsHub October 3, 2024 08:01
@lcomment lcomment self-assigned this Oct 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Test Results

212 tests   212 ✅  46s ⏱️
 40 suites    0 💤
 40 files      0 ❌

Results for commit 70a3f06.

@codecov Codecov
Copy link

codecov bot commented Oct 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../src/main/kotlin/com/cakk/api/mapper/ShopMapper.kt 0.00% 0 Missing and 2 partials ⚠️

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #220      +/-   ##
=============================================
- Coverage      92.14%   91.00%   -1.14%     
+ Complexity       329      235      -94     
=============================================
  Files            109       59      -50     
  Lines            967      589     -378     
  Branches          34       17      -17     
=============================================
- Hits             891      536     -355     
+ Misses            58       44      -14     
+ Partials          18        9       -9
Files with missing lines Coverage Δ Complexity Δ
.../src/main/kotlin/com/cakk/api/mapper/ShopMapper.kt 92.68% <0.00%> (ø) 0.00 <0.00> (?)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ed3b0a...70a3f06. Read the comment docs.

YongsHub
YongsHub approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@YongsHub YongsHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User 객체를 담는 부분에 대해 리팩토링이 필요할 것 같아요. 따로 대화 나누었을 때, 영속성 컨텍스트에서 유지가 안되다보니 어떤게 좋을지 생각해봐야겠습니당

@lcomment
Copy link
Collaborator Author

lcomment commented Oct 4, 2024

User 객체를 담는 부분에 대해 리팩토링이 필요할 것 같아요. 따로 대화 나누었을 때, 영속성 컨텍스트에서 유지가 안되다보니 어떤게 좋을지 생각해봐야겠습니당

그냥 Resolver에서 user.getId();로 id를 가져와 이후에 조회를 할지도 고민입니다. 조금만 더 고민해보죠!

@lcomment lcomment merged commit acbad42 into develop Oct 4, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YongsHub YongsHub YongsHub approved these changes

Assignees

@lcomment lcomment

Labels
chore 빌드 매니저 및 환경 설정 refactor 비즈니스 변경 없는 수정
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lcomment @YongsHub